Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip/ignore RestoreSnapshotIT to unblock 2.19 release #2486

Closed
wants to merge 1 commit into from
Closed

skip/ignore RestoreSnapshotIT to unblock 2.19 release #2486

wants to merge 1 commit into from

Conversation

anntians
Copy link
Contributor

@anntians anntians commented Feb 3, 2025

Description

  • Mute RestoreSnapshotIT test to unblock 2.19 release after confirmation with engineers on KNN team
  • Will need some time to root cause issue and fix, so muting to unblock release

Related Issues

Resolves #2458

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sohami
Copy link

sohami commented Feb 3, 2025

Fyi discussed with @anntians and release team. He is trying out a potential fix on local setup and see if that helps. Otherwise we can go ahead with ignoring for now.

@navneet1v
Copy link
Collaborator

Fyi discussed with @anntians and release team. He is trying out a potential fix on local setup and see if that helps. Otherwise we can go ahead with ignoring for now.

@sohami is there a timeline for the fix? Because these IT are blocking the release.

@sohami
Copy link

sohami commented Feb 3, 2025

Fyi discussed with @anntians and release team. He is trying out a potential fix on local setup and see if that helps. Otherwise we can go ahead with ignoring for now.

@sohami is there a timeline for the fix? Because these IT are blocking the release.

Yes I think he should be able to test it out in next couple of hours to take the call. Changing the manifest will not require any new RC generation as there won't be any code change in kNN plugin whereas ignoring it will require an RC generation. Hence I think spending some time to validate should be fine.

@kotwanikunal
Copy link
Member

There is a RC generation scheduled for today at 3:00pm PST.
@anntians please plan to merge this into the 2.19 branch by then if you'd like to ignore the test.

@anntians
Copy link
Contributor Author

anntians commented Feb 3, 2025

The functionality of the RestoreSnapshotIT tests were manually verified as well when the original PR for that IT was merged. So currently we're working on a fix for the configuration issue of the test cluster used in the release.

Hoping to get this PR approved so that it can be merged in the case we cannot get the fix done in time. Thanks

@sohami
Copy link

sohami commented Feb 3, 2025 •
edited
Loading

We don't need this as the change with manifest file update helped to resolve the issue: https://build.ci.opensearch.org/blue/organizations/jenkins/integ-test/detail/integ-test/9321/pipeline/

@kotwanikunal
Copy link
Member

Closing PR as it os no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navneet1v navneet1v navneet1v approved these changes

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@shatejas shatejas shatejas approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

@0ctopus13prime 0ctopus13prime Awaiting requested review from 0ctopus13prime 0ctopus13prime is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anntians @sohami @navneet1v @kotwanikunal @shatejas